This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(alert): remove replace: true usage #5986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `replace: true` usage BREAKING CHANGE: This removes the `replace: true` usage, so this has an effect on how one uses the directive in the template - see documentation for reference
| </script> | ||
|
|
||
| <uib-alert ng-repeat="alert in alerts" type="{{alert.type}}" close="closeAlert($index)">{{alert.msg}}</uib-alert> | ||
| <uib-alert template-url="alert.html">A happy alert!</uib-alert> | ||
| <div uib-alert ng-repeat="alert in alerts" ng-class="'alert-' + (alert.type || 'warning')" close="closeAlert($index)">{{alert.msg}}</div> |
There was a problem hiding this comment.
You removed the type atteibute from the docs but still reference it here. Is that just because it's our model def and we can call it whatever we want?
|
LGTM |
|
I wish the changelog comment had more information about what needed to be updated. For future reference, it wasn't clear to me what had changed so I missed the necessary changes to defining the alert type in my code. 🌹 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace: trueusageBREAKING CHANGE: This removes the
replace: trueusage, so this has an effect on how one uses the directive in the template - see documentation for referenceThis assists in #5712.