This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(typeahead): remove duplicate id attribute #5936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove any duplicate `id` attribute on the typeahead hint element if used on the original input element. BREAKING CHANGE: This change removes the `id` attribute on the first `<input>` element placed into the DOM when the `typeahead-show-hint` attribute is used and there is an `id` attribute present on the original `uib-typeahead` element. This could affect selectors if they are being used. Fixes angular-ui#5926
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idattribute on the typeahead hint element if used onthe original input element.
BREAKING CHANGE: This change removes the
idattribute on the first<input>element placed into the DOM when the
typeahead-show-hintattribute is usedand there is an
idattribute present on the originaluib-typeaheadelement.This could affect selectors if they are being used.
Fixes #5926