Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(loading): add "index-nocss.js" files #5696

Closed
wants to merge 1 commit into from

Conversation

onlywei
Copy link
Contributor

@onlywei onlywei commented Mar 26, 2016

This allows SystemJS users to load the individual
modules without setting up CSS loading. Some build
processes with using SystemJS would rather have
a custom, separate CSS loading solution. This
commit allows that to happen.

@wesleycho
Copy link
Contributor

This needs an exclusion added to https://github.com/angular-ui/bootstrap/blob/master/karma.conf.js#L29-L32

This allows SystemJS users to load the individual
modules without setting up CSS loading. Some build
processes with using SystemJS would rather have
a custom, separate CSS loading solution. This
commit allows that to happen.
@onlywei
Copy link
Contributor Author

onlywei commented Mar 26, 2016

Hmm, not really sure what this means:

Firefox 31.0.0 (Linux 0.0.0): Executed 1251 of 1251 SUCCESS (59.296 secs / 58.342 secs)
Running "build" task
FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
/home/travis/build.sh: line 45:  3364 Aborted                 (core dumped) grunt
The command "grunt" exited with 134.
Done. Your build exited with 1.

@wesleycho
Copy link
Contributor

Interesting failure - restarted the CI task

@wesleycho
Copy link
Contributor

Hmm, maybe Travis is having issues - I'll hold off for a few days and come back to it.

FWIW, this LGTM, and will likely be merged without any need for further changes on your end.

@wesleycho wesleycho closed this in de504fb Mar 26, 2016
@wesleycho wesleycho added this to the 1.3.0 milestone Mar 26, 2016
@wesleycho
Copy link
Contributor

I found out what was the error - it was a legitimate error where the Gruntfile also needed to be modified - I fixed it in master in two commits, shouldn't be an issue anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants