This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(rating): fix usage of aria-valuetext #5573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix usage to be on top level element
| @@ -8,7 +8,8 @@ angular.module('ui.bootstrap.rating', []) | |||
| }) | |||
|
|
|||
| .controller('UibRatingController', ['$scope', '$attrs', 'uibRatingConfig', function($scope, $attrs, ratingConfig) { | |||
| var ngModelCtrl = { $setViewValue: angular.noop }; | |||
| var ngModelCtrl = { $setViewValue: angular.noop }, | |||
| self = this; | |||
There was a problem hiding this comment.
Not that it really matters, but won't this.getTitle work in this situation, making self = this not needed?
Just like how this line works?
There was a problem hiding this comment.
It actually doesn't - I tried that first :(
There was a problem hiding this comment.
Hmmm, do you know why that does not work? Just curious.
There was a problem hiding this comment.
Because it is called in the render function, which is called in $scope.rate is my suspicion.
|
This LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5571.