This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): fix race condition with openedClass #5483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has only occurred on Firefox (v. 43.0.4) when the modal is opened on application startup and closed almost immediately after. I don't have a Plunker but the test case demonstrates the exact same execution order as on Firefox (and fails without the |
|
This LGTM - subtle, good catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
modal-windowentering animation runs after the modal has closedopenedClassis left tobodyelement.This pull request fixes the issue by checking if modal closing has been scheduled after the animation has finished.