-
Notifications
You must be signed in to change notification settings - Fork 6.7k
template-url attribute support #5405
Comments
That is pretty much correct. I will consider it. |
It should be noted that all components that support it has it mentioned in the documentation. This is missing though, and I believe I have seen that it was missing in the past, but I forgot to file a PR/issue implementing it for tabs. |
I've taken a look at the documentation and identified some of the work that needs to be done. The following components need
The following directives have a similar implementation but naming is inconsistent:
For directives with multiple templates, the naming scheme seems to be |
Better to open a new issue for that. It is not that inconsistent :P Modal is a service so that is why it is camelCase and not kebab-case. Datepicker is fine, that is the way it should be done (same with typeahead). Popover / tooltip is a bit different because those uib-xxx-template are directives and it is not a mere template-url option to override a concrete template. |
Collapse also has no template, and not sure it makes sense to have this feature for buttons either. |
overriding templates via attrs.templateUrl is not consistently implemented across directives.
some support it, others don't.
i specifically came across it trying to override uib-tab in order to remove the empty href.
The text was updated successfully, but these errors were encountered: