This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(accordion): use appropriate aria tags for accessibility #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something similar to bootstrap/src/typeahead/typeahead.js Line 113 in 3dac5e3 |
|
Ok, I will update it to be similar to that. Should I be adding the aria tags like bootstrap/src/typeahead/typeahead.js Line 114 in 3dac5e3 |
|
Template is fine |
|
It looks like the travis ci build failed because of a timeout issue, is there anyway to run a new build against this? |
|
Looks ok now. |
|
|
||
| var id = 'accordiongroup-' + scope.$id + '-' + Math.floor(Math.random() * 10000); | ||
| scope.headingId = id + '_tab'; | ||
| scope.panelId = id + '_panel'; |
There was a problem hiding this comment.
Can you switch these to - instead of _?
|
Just that switch in those two ids to dashes & this should be good. |
|
Awsome! Thanks for the feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id generation in accordion.js, seems a little sketchy - open to ideas about this.