Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(position): positionArrow descendant selector #5246

Merged
merged 1 commit into from
Jan 14, 2016
Merged

fix(position): positionArrow descendant selector #5246

merged 1 commit into from
Jan 14, 2016

Conversation

RobJacobs
Copy link
Contributor

  • The element selector was not limited to direct descendants so
    nested tooltip/popover arrow elements were getting selected instead
    of the direct descendant arrow element.

Fixes #5230

@RobJacobs
fix(position): positionArrow descendant selector
9f4c3a5 
- The element selector was not limited to direct descendants so
nested tooltip/popover arrow elements were getting selected instead
of the direct descendant arrow element.

Closes #5246
Fixes #5230
@RobJacobs RobJacobs self-assigned this Jan 14, 2016
@wesleycho
Copy link
Contributor

LGTM

@wesleycho wesleycho added this to the 1.0.4 milestone Jan 14, 2016
@RobJacobs RobJacobs merged commit 9f4c3a5 into angular-ui:master Jan 14, 2016
RobJacobs added a commit that referenced this pull request Jan 14, 2016
@RobJacobs
fix(position): positionArrow descendant selector
e8b6a83 
- The element selector was not limited to direct descendants so
nested tooltip/popover arrow elements were getting selected instead
of the direct descendant arrow element.

Closes #5246
Fixes #5230
@RobJacobs RobJacobs deleted the position-fix branch January 14, 2016 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@RobJacobs RobJacobs

Labels
component: $position needs: merging type: bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@RobJacobs @wesleycho