-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix(typeahead): Scroll only parent element, not page #5212
Conversation
I'm fine with this approach - @Foxandxss what is your thoughts? |
Fine for me, better if tested. |
Sounds good, will add tests within an hour or so after I finish some work up. Hope to make it into 1.0.1 if you don't mind waiting for an hour or two. |
That is fine by me. |
Just added tests. Thanks @wesleycho & @Foxandxss for the feedback and getting this into 1.0.1 |
That is actually a bug that has been existing for about 2-3 years on the demo page, but no fix yet. |
Ok but note that in the plunker without the fix (demo in 5180) I can't reproduce this last problem (at least not after 20 tries) (But I see the bug described in 5180 of course) |
I am planning to fix another bug out there while making the behavior a bit better. I will take a look at the issue you are describing @frfancha and see if I can't fix that also. @wesleycho, do you know if there is a ticket for that one? |
The positioning issue with the typeahead demo is the second mentioned in #1988 |
Closes #5180
Plunker demonstrating fix
Let me know if you want tests if this is a good solution. I can figure out a way to test it. FWIW does not look like this was being tested before.