[Collapse] First animation is still ran

[bogdanalexe90]

Collapse has a strange flickering when is opened by default at first rendering and some delayed content is loaded. I took a look in the collapse directive and the expand() logic is still ran.

// This should add `collapse in` class
if (!scope.$eval(attrs.uibCollapse)) {
          element.addClass('in')
            .addClass('collapse')
            .css({height: 'auto'});
}

function expand() {
    ...
          if ($animateCss) {
            $animateCss(element, {
              addClass: 'in',
              easing: 'ease',

              // if the async content is loaded after this
              // it will cause an animation towards the new scrollHeight

              to: { height: element[0].scrollHeight + 'px' }
            }).start()['finally'](expandDone);
          } else {
            ...
          }
        }

// Still the watcher will trigger expand logic
scope.$watch(attrs.uibCollapse, function(shouldCollapse) {
          if (shouldCollapse) {
            collapse();
          } else {
            expand();
          }
        });

Because we need to skip expand() only for the first rendering we can add a simple check inside the watcher:

scope.$watch(attrs.uibCollapse, function(shouldCollapse) {
          if (shouldCollapse) {
            collapse();
          } else {
            if(arguments[0] !== arguments[1]){
                expand();
            }
          }
        });

[icfantv]

@bogdanalexe90, per these instructions, can you please post a plunker that reproduces the issues? Doing this for bugs usually greatly reduces the time it takes for us to diagnose and fix issues. Thanks.

[bogdanalexe90]

Please have a look on #4414 it's the same issue. Also you can have a look on my pull request #5199

[icfantv]

Awesome, thanks.