Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat: add npm support in main repository #5129

Closed
wants to merge 1 commit into from

Conversation

wesleycho
Copy link
Contributor

  • Add support for consuming the main repository via npm for releases

This addresses #4739.

@wesleycho wesleycho added this to the 1.0.0 milestone Dec 27, 2015
@wesleycho
Copy link
Contributor Author

This may still require a docs update - any recommendation for where to put that @Foxandxss ?

@wesleycho
Copy link
Contributor Author

Hmm this is not quite right - need to define the ui.bootstrap module still.

@wesleycho
Copy link
Contributor Author

My thoughts - we will want to document usage of this, as this is a major change.

There is no good way to bundle template support, but we can point people to some loaders such as https://github.com/teux/ng-cache-loader and https://github.com/WearyMonkey/ngtemplate-loader for Webpack and https://www.npmjs.com/package/browserify-ng-html2js for Browserify. We could perhaps provide a template.js helper file that does a bunch of requires for the templates, creates a ui.bootstrap.tpls module and export that, and import it into the index.js to maintain consistency with the previous complete bundle. This would require people are using Browserify or Webpack, and have the proper config setup for requiring HTML templates.

Edit: Hmm, looks like the different tools handle template bundling & loading differently. Maybe best to let the users use it however they desire and not do anything here except document it.

@Foxandxss
Copy link
Contributor

Yeah, we have our hands a bit tied in regard of what we can provide. All we can do is to document the different options.

I will think in how can we make it as easy as possible.

- Add support for consuming the main repository via npm for releases
@wesleycho
Copy link
Contributor Author

Cleared by @Foxandxss

@wesleycho wesleycho closed this in a9e476f Jan 8, 2016
@wesleycho wesleycho deleted the feat/npm branch January 8, 2016 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants