This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tabs): added controllerAs for tab controller #5020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs tests. |
|
@wesleycho Done |
| @@ -98,6 +98,10 @@ describe('tabs', function() { | |||
| titles().eq(1).find('> div').click(); | |||
| expect(scope.deselectFirst).toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| it('should expose controller as "tab" scope variable', function() { | |||
| expect(typeof elm.find('.uib-tab').first().isolateScope().tab).toEqual('object'); | |||
There was a problem hiding this comment.
Using a typeof check is not great, and this test is a little too vague. It would be better to test against what it equals exactly.
There was a problem hiding this comment.
I believe the only way to do this is:
it(..., inject(function(uibtabDirective) {
expect(elm.find('.uib-tab').first().isolateScope().tab).toBeInstanceOf(uibtabDirective[0].controller);
}));Let me know if you are ok with such solution
There was a problem hiding this comment.
Check how some of the other tests for the other components is testing for controllerAs working - those are more useful guides as far as a readable test for this feature are written.
There was a problem hiding this comment.
@wesleycho Ok, thanks for pointing me to the right direction. Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it fixes #5019