Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

hide tooltips and popovers when a user clicks away (corrected) #4871

Closed
wants to merge 2 commits into from
Closed

hide tooltips and popovers when a user clicks away (corrected) #4871

wants to merge 2 commits into from

Conversation

aaronleesmith
Copy link

Please refer to #4419 for complete context. This pull request fixes the issues that cause the Travis CI build to fail.

SystemDisc and others added 2 commits November 9, 2015 22:56
@SystemDisc
feat(tooltip): add outsideClick trigger to tooltips/popovers
b48bd7f 
outsideClick will open a tooltip/popover on click and close that
tooltip/popover when a click happens that is not targeting a
tooltip/popover trigger element or a tooltip/popover itself
@aaronleesmith
Fixes null equality checks.
90c2560 
These checks don't pass the linting requirements of the Travis build. This fixes them and should fix the build.
@aaronleesmith aaronleesmith mentioned this pull request Nov 10, 2015
Closed
@wesleycho wesleycho closed this in 8737303 Nov 10, 2015
@SystemDisc
Copy link
Contributor

@thegreenpizza and @wesleycho

I used XYZ == null to check if XYZ is null or undefined. If the linter doesn't like the ==, this should probably be changed from XYZ == null to !XYZ, instead of XYZ === null.

I know this was already committed to master, but I just wanted to let you guys know that you broke my check - it's now only checking whether or not the variable is strictly null or not.

@wesleycho
Copy link
Contributor

@SystemDisc can you file a PR with the fix?

@SystemDisc
Copy link
Contributor

@wesleycho Yeah, I can do that tomorrow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronleesmith @SystemDisc @wesleycho