Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(dateparser): add new format support #4833

Closed

Conversation

wesleycho
Copy link
Contributor

  • Adds ww support
  • Adds w support
  • Adds G, GG, GGG support
  • Adds GGGG support

Should be noted, this almost finishes off #3418

- Adds `ww` support
- Adds `w` support
- Adds `G`, `GG`, `GGG` support
- Adds `GGGG` support
@Foxandxss
Copy link
Contributor

I can see week, but the other are a bit weird, not sure if they are going to be used, ever.

About #3418, I think it is implemented (we have a and short, medium....)

@wesleycho
Copy link
Contributor Author

I'm not sure the era ones will ever be used, but it's nice to have the option, and it doesn't cost us much. It completes parity with the Angular dateFilter.

About short, medium, etc., how do we support that? I don't see anything obvious in the dateparser that allows for it.

@Foxandxss
Copy link
Contributor

Using: https://github.com/angular-ui/bootstrap/blob/master/src/dateparser/dateparser.js#L219-L220

that will translate short, mediumDate, etc into a string that can be tokenized later.

@wesleycho
Copy link
Contributor Author

Oh, so the issue will be finished then by this PR.

@Foxandxss
Copy link
Contributor

Yes sir. Merge this
El 7/11/2015 4:56 p. m., "Wesley Cho" [email protected] escribió:

Oh, so the issue will be finished then by this PR.


Reply to this email directly or view it on GitHub
#4833 (comment)
.

@wesleycho wesleycho closed this in ea388b3 Nov 7, 2015
@wesleycho wesleycho deleted the feat/dateparser-formats branch November 7, 2015 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants