Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(datepicker): add disabled and ngDisabled support #4814

Closed

Conversation

wesleycho
Copy link
Contributor

  • Adds support for disabled attribute
  • Adds support for ng-disabled

This implements #4059.

- Adds support for `disabled` attribute
- Adds support for `ng-disabled`
@Foxandxss
Copy link
Contributor

I am not too fond of using disable in here because it is only meant for concrete elements. I think that ngDisabled is enough.

All things considered, not that Angular is respecting all conventions in HTML

@wesleycho
Copy link
Contributor Author

My reasoning is that we are treating this as a control, so we should try to hook into the descriptive native to implement the behavior desired. I know disabled has a particular semantic, but I think it's ok to use it, as long as we are disabling things sensibly.

I forgot to link it, but here is the Plunker in action.

@Foxandxss
Copy link
Contributor

Yeah, I think it makes sense, to have a read only datepicker. Go for it.

@wesleycho wesleycho closed this in 434c602 Nov 3, 2015
@wesleycho wesleycho deleted the feat/datepicker-disabled branch November 3, 2015 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants