This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): correctly display pre-100 years #4812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix display of dates in datepicker for years less than 100
| @@ -246,6 +246,7 @@ angular.module('ui.bootstrap.dateparser', []) | |||
| dt = new Date(fields.year, fields.month, fields.date, | |||
| fields.hours, fields.minutes, fields.seconds, | |||
| fields.milliseconds || 0); | |||
| dt.setFullYear(fields.year); | |||
|
Can you explain to me how this work? I made a note but then realized that all the PR was add stuff like that and I don't follow the idea. |
|
The problem with setting a date with |
|
I see. Good for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a Plunker in action.
This fixes #4032.