This repository has been archived by the owner on May 29, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.done
is not triggering any $digest and we need that..finally
will do it (you can read the docs for that bit).Fixes:
First one: If there is a hidden element on screen, $animateCss will compute its height:
Broken Plunker, no ngAnimate
(Works with ngAnimate)
Fixed Plunker, no ngAnimate
(Works the same with ngAnimate)
Second one: I don't know how to explain this one, but with $animateCss, it is not showing the navbar correctly (just drag it for the responsive behavior):
Broken Plunker, no ngAnimate
(Works with ngAnimate)
Fixed Plunker, no ngAnimate
(Works the same with ngAnimate)
Third one: Nested accordions not being rendered correctly:
Broken Plunker, no ngAnimate
(Works with ngAnimate)
Fixed Plunker, no ngAnimate
(Works the same with ngAnimate)
As you can see, the issue comes when you don't use ngAnimate.
There is also a bug that makes the animations to flicker, but that got fixed in 1.4.5 (1.3.x doesn't have the issue).
Fixes #4647
Fixes #4628
Fixes #4561