Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(collapse): trigger digest after #4651

Closed

Conversation

Foxandxss
Copy link
Contributor

.done is not triggering any $digest and we need that. .finally will do it (you can read the docs for that bit).

Fixes:

First one: If there is a hidden element on screen, $animateCss will compute its height:

Broken Plunker, no ngAnimate
(Works with ngAnimate)
Fixed Plunker, no ngAnimate
(Works the same with ngAnimate)

Second one: I don't know how to explain this one, but with $animateCss, it is not showing the navbar correctly (just drag it for the responsive behavior):

Broken Plunker, no ngAnimate
(Works with ngAnimate)
Fixed Plunker, no ngAnimate
(Works the same with ngAnimate)

Third one: Nested accordions not being rendered correctly:

Broken Plunker, no ngAnimate
(Works with ngAnimate)
Fixed Plunker, no ngAnimate
(Works the same with ngAnimate)

As you can see, the issue comes when you don't use ngAnimate.

There is also a bug that makes the animations to flicker, but that got fixed in 1.4.5 (1.3.x doesn't have the issue).

Fixes #4647
Fixes #4628
Fixes #4561

@Foxandxss
Copy link
Contributor Author

Btw, I am not sure if this can be tested, animations are a mystery and I don't know if I simulate that I don't load ngAnimate (well, I don't think it is loaded, but I can't test those different behaviors).

@wesleycho
Copy link
Contributor

LGTM

@wesleycho wesleycho added this to the 0.14.3 milestone Oct 18, 2015
@Foxandxss Foxandxss closed this in 3144633 Oct 18, 2015
@Foxandxss Foxandxss deleted the fix/animationcssdigest branch October 18, 2015 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants