This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): ensure class is present in dropdown-menu #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure `dropdown-menu` class is present when using as an attribute directive - Refactor `DropdownController` to be more agnostic of directive
|
From ignorance on the issue, this doesn't need tests? |
|
I could write a test, but it seems pretty trivial of a change to me & not really function - what are your thoughts? |
|
Alright, I had to ask. I was going to do that refactor too when I reached the D on my rewrite (which doesn't seem to move that much lately) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropdown-menuclass is present when using as an attributedirective
DropdownControllerto be more agnostic of directiveThis fixes #4442.