feat(accordion): allow custom panel class #4242
Conversation
* add support for custom panel class fixes angular-ui#3968
| @@ -1,4 +1,4 @@ | |||
| <div class="panel panel-default"> | |||
| <div class="panel panel-{{panelClass || 'default'}}"> | |||
There was a problem hiding this comment.
I think I would prefer this be {{panelClass || 'panel-default'}} - gives the users of the library a little more flexibility without any cost.
There was a problem hiding this comment.
I really went back and forth here on this (as well as putting the default inside the directive ala scope.panelClass = attrs.panelClass || 'panel-default'; but opted for what I did so as to keep the code as close to the element as possible) but ultimately decided to mimic what we do in tabs.
Recall that we did talk about only supporting the built-in contextual panel classes from Bootstrap - which is also why I went this route.
But I don't have a strong feeling either way and if we want to be totally flexible that solution would do it.
There was a problem hiding this comment.
There are some users of the library who use it with custom CSS or other CSS libraries - I think we should try to be less opinionated here for minimal pain.
* add support for custom panel class fixes angular-ui#3968
|
LGTM |
fixes #3968