This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): handle keyboard-nav correctly
#4110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix bug in directive whereby list item selector is not being initiated on correct DOM element. - fix bug in directive whereby invalid `keyCode` property of jQuery Event object is being referenced instead of `which`. - update functional test to trigger keydown event on correct DOM element because otherwise the keydown handler in the directive is not getting executed. - remove invalid functional test because it is not possible to trigger a keydown event on a hidden DOM element through normal UI interaction. fixes angular-ui#4091
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct DOM element.
keyCodeproperty of jQuery Eventobject is being referenced instead of
which.because otherwise the keydown handler in the directive is not getting
executed.
keydown event on a hidden DOM element through normal UI interaction.
fixes #4091