This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): dismiss modal on unschedule destruction #4097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
fix/modal-scope
branch
from
be2fd2c to
05ce74c
Compare
|
Smart solution. Perhaps this needs tests? |
|
I'll write up a test tomorrow - should be easy. |
|
What are your thoughts on what the dismissal should reject the promise with? I just chose an arbitrary string to have something that can be hooked to, but I'm not partial to any particular form of the api there. |
|
Yup, need tests. |
- Dismiss modal via `modalInstance.dismiss` if the `$scope` undergoes an unscheduled destruction
wesleycho
force-pushed
the
fix/modal-scope
branch
from
05ce74c to
2f8a064
Compare
|
Added test |
|
I don't mind the string chosen. It just need one unique. |
|
@wesleycho sorry, didn't see your reply until now, |
|
Sure, I can change that right now. |
wesleycho
added a commit
that referenced
this pull request
Aug 5, 2015
- Change to `$uibUnscheduledDestruction` as per comment in #4097
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modalInstance.dismissif the$scopeundergoes an unscheduled destructionPlunker in action here
This fixes #3694.