Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(accordion): add templateUrl support #4084

Closed

Conversation

wesleycho
Copy link
Contributor

  • Add ability to override the template of the accordion and accordion-group directives on an instance by instance basis

- Add ability to override the template of the `accordion` and `accordion-group` directives on an instance by instance basis
@wesleycho wesleycho added this to the 0.13.3 (Performance) milestone Aug 3, 2015
@Foxandxss
Copy link
Contributor

I am not any sure we want this kind of upgrades. The whole point of having the tpls is to include the templates. You can always use the other version if you don't want the templates.

Still, you can override the templates in the tpls version with $templateCache easily.

@wesleycho
Copy link
Contributor Author

This would let you override it on a case-by-case basis - say you want one template for one instance and another for a different one

@Foxandxss
Copy link
Contributor

Uhmm, uhmmm. I can see that.

I would put in the doc that it only accepts a string, no interpolation.

@wesleycho
Copy link
Contributor Author

Alright, I'll make the change - my test has a bit of a hack in it btw. Is it fine or do you have a better recommendation there?

@wesleycho wesleycho closed this in f777c32 Aug 4, 2015
@wesleycho wesleycho deleted the feat/accordion-template-url branch August 4, 2015 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants