This repository has been archived by the owner on May 29, 2019. It is now read-only.
fixes angular-ui/bootstrap#4018 #4027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (totalPercentage > 100) { | ||
| bar.percent -= totalPercentage - 100; | ||
| } else if (totalPercentage < 100) { |
There was a problem hiding this comment.
The else if should be removed - this is causing the tests to fail. We also should not assume that the bar should fill up the progress section.
There was a problem hiding this comment.
Sorry, my mistake. I failed to realize the possible scenario of bars that do not reach the progress max. I'll remove that.
|
Could you also write a test with three stacked bars, each with values that total 100% but round to greater than 100%? |
|
Linking #4018 for reference. |
|
Sure thing. |
|
I adjusted the code and added a test case. |
|
This looks good - thanks for the good work here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.