Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

'restrict' for dropdown and dropdownToggle #3868

Closed
djvs opened this issue Jun 29, 2015 · 5 comments
Closed

'restrict' for dropdown and dropdownToggle #3868

djvs opened this issue Jun 29, 2015 · 5 comments

Comments

@djvs
Copy link

djvs commented Jun 29, 2015

Why was this removed? Broke my code during upgrade. Manually went in the minified code and added restrict:'AC' for both, so that I didn't have to edit every instance of popover in my app. Using 0.13.0 stable.

@pkozlowski-opensource
Copy link
Member

See https://github.com/angular-ui/bootstrap/blob/master/CHANGELOG.md#breaking-changes

It was removed based on the discussion in #2156

@pkozlowski-opensource
Copy link
Member

BTW: having directives matching CSS classes (C) is discouraged in AngularJS, generally speaking.

@djvs
Copy link
Author

djvs commented Jun 29, 2015

I could be wrong, but I don't think this is mentioned on the changelog either, at least not as a breaking change.

@pkozlowski-opensource
Copy link
Member

@djvs I've linked to an entry to a CHANGELOG.....

@djvs
Copy link
Author

djvs commented Jun 29, 2015

Ah sorry, still waking up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants