Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Typeahead matches don't show cursor pointer #3649

Closed
OzzieOrca opened this issue May 11, 2015 · 5 comments
Closed

Typeahead matches don't show cursor pointer #3649

OzzieOrca opened this issue May 11, 2015 · 5 comments

Comments

@OzzieOrca
Copy link
Contributor

When hovering over the typeahead matches, they work fine but the cursor is not a pointer (hand) but instead alternates between an arrow and a text select cursor (when hovering over text).

This could be fixed by changing template/typeahead/typeahead-match.html from

<a tabindex="-1" bind-html-unsafe="match.label | typeaheadHighlight:query"></a>

to

<a tabindex="-1" bind-html-unsafe="match.label | typeaheadHighlight:query" style="cursor: pointer"></a>

We could also add a CSS file to apply that style. Or add a blank href but that might cause other issues.

Do any of these seem like good approaches? I can submit a PR adding this if it seems like a good change.

@karianna
Copy link
Contributor

@OzzieOrca I'd say the CSS approach is best, PR welcome!

@karianna karianna added this to the 0.13.x milestone May 11, 2015
@RobJacobs
Copy link
Contributor

In the accordion-group template, heading element, the href attribute on the anchor tag is:

href=\"javascript:void(0)\"

@pkozlowski-opensource
Copy link
Member

I'd say the CSS approach is best

Currently we don't have any CSS deliverable in this project and IMO we should keep it like this.

@karianna
Copy link
Contributor

@pkozlowski-opensource & @OzzieOrca - I stand corrected!

@OzzieOrca
Copy link
Contributor Author

So javascript:void(0) is the best option? I can submit a PR soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants