This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): skipping ESC handling for form inputs; fixes #2544 #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks expected behavior as I mentioned in #2544 . Discussing there. |
|
done |
| @@ -251,6 +251,10 @@ angular.module('ui.bootstrap.modal', []) | |||
| } | |||
|
|
|||
| $document.bind('keydown', function (evt) { | |||
| if (evt.isPropagationStopped() || /^(?:input|textarea|select)$/i.test(evt.target.nodeName)) { | |||
There was a problem hiding this comment.
Is this supposed to be evt.defaultPrevented? https://developer.mozilla.org/en-US/docs/Web/API/Event/defaultPrevented
There was a problem hiding this comment.
ah, true!
also, forgot to remove the form input check
on it
There was a problem hiding this comment.
went with evt.isDefaultPrevented()
|
This LGTM, based on the comments in the issue. |
|
I had to do a few minor tweaks since there have been updates since this PR, but got the tests passing & did some minor cleanup. Thanks! |
|
🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added
scriptssection inpackage.jsonto speed up figuring out which task is for testing ;-)