Issue #3511 fixed

[jainsneha23]

Call on-toggle function of dropdown in resolve function of $animate

[chrisirhc]

It looks like with this change, you need to do $browser.defer.flush() in the dropdown.spec for the failing tests because the toggleHandler is now deferred.

[rvanbaalen]

Since this related issue, #3511, is labeled Angular 1.3 I've added the Angular 1.3 label here as well.
@chrisirhc isn't this part of Angular 1.3 support?

[chrisirhc]

@rvanbaalen not exactly, it's actually an ngAnimate issue but nonetheless we should try to have this fixed for next release.

[chrisirhc]

@snehatulsi , could you please add $browser.defer.flush() in the test code so that the tests pass?

[jainsneha23]

I don't know where is the test, and where can I add the code. Can you please help me out.

[chrisirhc]

No problem, the tests are located at: https://github.com/angular-ui/bootstrap/blob/master/src/dropdown/test/dropdown.spec.js

You can see the failures when you run grunt on your command line once you've prepared your environment.
The test failures will indicate the lines where it's failing at like:

[jainsneha23]

@chrisirhc I tried adding the code. I got the error $browser not defined. I tried with modifications, but failed. I don't know the test specs, I have never done testing this way. Please mention where to inject $browser dependency, and where to insert code for $browser.defer.flush()

[chrisirhc]

Use _$browser_ here

[chrisirhc]

Added a comment. You need to add the flush calls just before the expect calls on the lines that they're failing.

The flush call ensures that all promises have been resolved, since you moved the toggleHandler to be called in a then. It's required for the tests to get to the correct state before calling expect.

[jainsneha23]

@chrisirhc The test passed

[karianna]

@snehatulsi Can you update this PR, it can no longer be merged against master

[wesleycho]

Can you squash your commits & rebase off of master?