fix(popover): make it work with ngAnimate

[chrisirhc]

Fixes #3375

[wesleycho]

The previous value in the template was a binding - is this change ok as an immediately run class add?

Does this work when the user does not use ngAnimate?

[chrisirhc]

Yep it works, it needs to be added immediately because otherwise ngAnimate attempts to animate the animation class (fade) along with the in class at the same time.

This PR ensures that the fade class is already there when the in class is added.

[chrisirhc]

Actually, good question, on further thought, I'll detect that if ngAnimate doesn't exist, skip adding the animation classes.
Edit: I'll work on that in another PR as the tooltip requires some more changes for full ngAnimate support.

[wesleycho]

This good for merging then?

[chrisirhc]

Yep it is. Does fix the popover issues.

On Mon, Apr 6, 2015, 06:13 Wesley Cho [email protected] wrote:

This good for merging then?

—
Reply to this email directly or view it on GitHub
#3482 (comment).