This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(typeahead): implement 'select on blur' option. #3445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests and it currently fails the build... |
|
Ok, I'm working on it... Thanks! |
|
I have added two tests. Let me know if they are good enough. Thanks. |
|
I like this - scheduling this to be merged for the next release (we've locked down 0.13.0 right now for Angular 1.3 compatibility). Can you add documentation? |
|
Thanks a lot ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option 'select on blur' on typeahead. When enabled, this option selects the current highlighted value (in popup list) when the widget is losing focus. In short : clicking outside the widget is identical to hitting the 'tab' key.
By default, this option is disabled.