Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Dialog: Line break in templateUrl with IE7/8 #328

Closed
enkelmedia opened this issue Apr 16, 2013 · 2 comments
Closed

Dialog: Line break in templateUrl with IE7/8 #328

enkelmedia opened this issue Apr 16, 2013 · 2 comments

Comments

@enkelmedia
Copy link

When I was setting up a dialog like this everything worked fine in IE9, Chrome and FF but in IE7+8 i got an strange error just saying "[object Error]undefined " to the log.

This code is used:

$scope.opts = {
...
templateUrl: '/CreateNewTripView.html',
controller: 'TestDialogController'
};

$scope.openDialog = function () {

    var d = $dialog.dialog($scope.opts);
    d.open();

}

After trying to remove all code from CreateNewTripView and its controller i added just a H3 and it worked. BUT. When i added a linebreak before the h3 in crashed in ie7+8.

So if the first line in the template is a line break it will crash.

@pkozlowski-opensource
Copy link
Member

I've got an impression that this one will be fixed by #339

@jonbcard
Copy link
Contributor

@pkozlowski-opensource Correct. I've tested this issue before/after the fix on #339 and can confirm that this was the same culprit. IE7/8 seems to add a text-node for the new line.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants