fix(typeahead): resolves property length of undefined error #2999

[unkleara]

An error is thrown that matches.length is not defined. So we check if matches is truthy first.

[antoinepairet]

@unkleara thanks for the PR. Do you think you can write a test for this?

[unkleara]

Opps I changed deferred.resolve(['good', 'stuff']); to deferred.resolve(['good1', 'stuff']); to make sure I was logging a correct area. Want me to change that back?

Let me know any adjustments that need to be made. It can be tested other places but it makes most sense testing it within the promise since it's going through that function first.

[antoinepairet]

Yes please change it back.
Thanks for the test.
We will review it and merge it asap (I am on mobile now, so I cant review proprly)

[stmichael]

👍 I'm having the same issue. Is there any progress on this issue? I'd really appreciate it, if it could be merged.

[johnnyreilly]

Is there any update on this? Also causing me issues...

[wesleycho]

Is there a particular reason why it returns as undefined?

[chrisirhc]

There's no reason for expecting that since it's always undefined. I'm removing that expect call as I merge.