-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Dropdown's do not work when Toggling with two Buttons #3004
Comments
I noticed our drop-down button is no longer working as well. If I include the bootstrap.js file it begins working. I'll investigate further and see what I can find. |
allentong, in my case the reason the drop down stopped working is because we are using a class directive instead of an attribute directive. In angular 1.3.3 the class directive is not supported unless it is specifically declared in the "restrict" property:
I've created a pull request that adds support for triggering off css classes on the dropdown component. Please review the pull request here: #3007 |
Yeah, I think I can close this ticket once that pull request is accepted. Thanks! |
See #2156 . We've intentionally removed support for class directives for dropdowns. Is there a reason you need this to be a class directive and can't use this as an attribute directive? |
Yes, in my case I can change to using an attribute instead of a class. However, my concern is that we shouldn't be including the bootstrap.js file in our projects if we are using angular ui bootstrap correct? The docs read:
|
I'm a bit confused. Why would someone include Bootstrap.js if they are using this library? |
@RobJacobs I agree and that was my point; we shouldn't include bootstrap.js if we are using angular-ui-bootstrap. If we don't include bootstrap.js then we shouldn't run into the problem with the class directives. IMO the correct approach to solving the problem would be to remove bootstrap.js from a project and update all instances that depended on it to use angular-ui-bootstrap. Is that not the correct approach? |
I am closing this as |
Since updating to 0.12, some of the functionality on my site stopped working.
We had set up two buttons as "dropdown-toggle", but now since we updated I cannot have two button(element) toggles under a single "dropdown" directive.
Adding Plunker later on.
The text was updated successfully, but these errors were encountered: