-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Progress directive overrides HTML 5 <progress> element. #2429
Comments
Yeah, this is one thing that has always kind of bothered me about this library in that it doesn't follow the Angular best practice of namespacing directive names (assuming this best practices doc is up-to-date). That said, it hasn't caused any problems for me yet so it hasn't really bothered me too much. |
I second @scottopherson comment. I just added angular-ui-bootstrap dependency and it killed my I suggest restricting the progress directive to attributes only (i.e. |
+1 |
I agree with @scottopherson, I would really like some better namespacing in the library. |
+1 please. Prefixing would be great |
+1 |
Will be fixed via #157 , moving milestone to align with that issue. |
This should now be fixed. |
Sorry, closed prematurely - this is still an issue for stacked bars. |
+1, this is getting ridiculous, especially now, when HTML5 is being so widely used... |
It's not so simple - changing this is a breaking change, and guaranteed to break apps. In addition there are a lot of feature requests/bug fixes that also need addressing, and short manpower. If someone were to put together a high quality PR, it would be reviewed and merged in, but nobody has stepped up to the plate to contribute. |
I'm going to close this, as we have already marked the |
The HTML 5 progress element (http://www.w3.org/html/wg/drafts/html/CR/forms.html#the-progress-element) gets overridden by the progress directive here (https://github.com/angular-ui/bootstrap/blob/master/src/progressbar/progressbar.js).
I realize we could create our own build and just not include the progress bar, but that would prevent us from using bower to keep up to date as well.
The text was updated successfully, but these errors were encountered: