Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Progress directive overrides HTML 5 <progress> element. #2429

Closed
blindworld opened this issue Jul 7, 2014 · 12 comments
Closed

Progress directive overrides HTML 5 <progress> element. #2429

blindworld opened this issue Jul 7, 2014 · 12 comments

Comments

@blindworld
Copy link

The HTML 5 progress element (http://www.w3.org/html/wg/drafts/html/CR/forms.html#the-progress-element) gets overridden by the progress directive here (https://github.com/angular-ui/bootstrap/blob/master/src/progressbar/progressbar.js).

I realize we could create our own build and just not include the progress bar, but that would prevent us from using bower to keep up to date as well.

@scottopherson
Copy link

Yeah, this is one thing that has always kind of bothered me about this library in that it doesn't follow the Angular best practice of namespacing directive names (assuming this best practices doc is up-to-date). That said, it hasn't caused any problems for me yet so it hasn't really bothered me too much.

@RodolpheGohard
Copy link

I second @scottopherson comment. I just added angular-ui-bootstrap dependency and it killed my <progress> element. I think the library should'nt downgrade or conflicts with HTML5.

I suggest restricting the progress directive to attributes only (i.e. restrict: 'A' in config)?

@bzitzow
Copy link

bzitzow commented Jan 27, 2015

+1

@ryanhburbank
Copy link

I agree with @scottopherson, I would really like some better namespacing in the library.

@LeDeep
Copy link

LeDeep commented Jan 27, 2015

+1 please. Prefixing would be great

@karianna karianna modified the milestones: 0.13, Backlog Jan 27, 2015
@JobaDiniz
Copy link

+1

@chrisirhc
Copy link
Contributor

Will be fixed via #157 , moving milestone to align with that issue.

@chrisirhc chrisirhc modified the milestones: 1.0, 0.13.0 Mar 23, 2015
@wesleycho
Copy link
Contributor

This should now be fixed.

@wesleycho
Copy link
Contributor

Sorry, closed prematurely - this is still an issue for stacked bars.

@grzegorzjudas
Copy link

+1, this is getting ridiculous, especially now, when HTML5 is being so widely used...

@wesleycho
Copy link
Contributor

It's not so simple - changing this is a breaking change, and guaranteed to break apps.

In addition there are a lot of feature requests/bug fixes that also need addressing, and short manpower.

If someone were to put together a high quality PR, it would be reviewed and merged in, but nobody has stepped up to the plate to contribute.

@wesleycho
Copy link
Contributor

I'm going to close this, as we have already marked the progress element directive as deprecated and it is scheduled to be removed in 1.0.0 along with all of the non-prefixed directives.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests