Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Datepicker popup not respecting show-weeks=false #2216

Closed
ronnieoverby opened this issue May 17, 2014 · 15 comments
Closed

Datepicker popup not respecting show-weeks=false #2216

ronnieoverby opened this issue May 17, 2014 · 15 comments

Comments

@ronnieoverby
Copy link

Same as #1132.

I'm on 0.11.0.

@ronnieoverby
Copy link
Author

BTW why is it true by default? It's a dumb feature IMHO. No offense.

@bekos
Copy link
Contributor

bekos commented May 17, 2014

@ronnieoverby show-weeks is no longer a watched attribute, you have to pass it through the datepicker-options. You can change the configuration from a single point in your application, if you want to turn this off by default, and don't have to pass this in every datepicker!

@gilluminate
Copy link

Documentation should be updated to reflect that.

@russmatney
Copy link

+1 docs need a quick fix

@jrgunawan
Copy link

+1 docs needs to be updated

@chrisirhc
Copy link
Contributor

I think the documentation already does mention that:

Options for datepicker can be passed as JSON using the datepicker-options attribute.

At nowhere does it mention that show-weeks can be used as an attribute when using a datepicker popup.

@russmatney
Copy link

The line you mentioned does exist in the docs - however, under "Datepicker Settings" (where show-weeks is actually listed, it also says:

All settings can be provided as attributes in the datepicker or globally configured through the datepickerConfig.

Perhaps the use of "attributes" here is misleading, and "properties" wouldn't lead to as much confusion? Now that I'm looking at it again, I can see you've got a little Eye icon next to some of these options too - this must mean something! I didn't notice that icon at all until I was thinking about how these docs could be more readable. The current state of the docs lead me to believe all the Datepicker Settings could be listed as attrs for the datepicker directive in the html itself.

@kosz
Copy link

kosz commented Dec 19, 2014

The plunker referenced on the examples page (http://angular-ui.github.io/bootstrap/) still has show-weeks as a html attribute. It gets even funnier, as the attribute works like a charm in the plunker :)

Also i'm not sure why a setting like this can't be configured on the html side. I feel having to keep these settings on the scope, promotes unwanted coupling.

@iyeldinov
Copy link

+1 docs need an update

@gitnik
Copy link

gitnik commented Mar 27, 2015

👍 this is super confusing

@yabasha
Copy link

yabasha commented Mar 28, 2015

+1 to super confusing, the documentation needs to be more clear

@prettycode
Copy link

+1

@holimL
Copy link

holimL commented Jun 22, 2015

Was wondering the exact same thing. +1.
Also the CDNs on its plunker doesn't seem to work anymore. They hang.

@wesleycho wesleycho removed the PRs plz! label Aug 6, 2015
@wesleycho
Copy link
Contributor

It should be noted that any attribute without an eye icon is not supported for watching. The documentation makes this clearer in master with an explanation in the first few paragraphs.

As a consequence, closing this as resolved.

@MuhammadTayyeb
Copy link

hi i have issue occur in angular datepicker after edit dateTime. that can't show the datetime. in Html dateTime aleardy exit but i can't show on UI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests