Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Hard coded modal animations #2210

Closed
skrivanos opened this issue May 16, 2014 · 4 comments
Closed

Hard coded modal animations #2210

skrivanos opened this issue May 16, 2014 · 4 comments

Comments

@skrivanos
Copy link

I noticed that the modal animations are hard coded right now. It is possible to avoid most issues with some CSS magic and/or template overriding but one thing that's impossible to fix is a delay when closing the modal window. See these lines:

https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L159
https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L170

A parameter called emulateTime is passed into the function removeAfterAnimate with the values 300 and 150 respectively, which makes closing the modal look sluggish.

There should be a way to disable animations all together.

@chrisguerrero
Copy link

I'm currently experiencing the same issue. I've overridden the window template to remove the fade-in effect, but these hard coded values produce a perceived delay when closing the modal.

@macav
Copy link

macav commented Jun 4, 2014

I agree that there should be a way to disable/replace animations and it leads me to one issue i discovered recently.
When I included ngAnimate, animations looked sluggish on iOS. It looked like it was being animated twice or what.. so I replaced scope.animate = true with $animate.addClass and scope.animate = false with $animate.removeClass, and then it was working fine.. But i'm not sure if it is desired to have ngAnimate as a dependency..

@chrisirhc
Copy link
Contributor

@macav , could you test if #1772 merging helps?

@pkozlowski-opensource
Copy link
Member

It is duplicate of #1007, let's move the discussion there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants