From df211bd62517827f1d4c4870151eac007e5da167 Mon Sep 17 00:00:00 2001
From: Wesley Cho <wesley.cho@gmail.com>
Date: Fri, 30 Oct 2015 19:52:33 -0700
Subject: [PATCH] fix(accordion): fix unexpected routing

- Change anchor tag to `div` to prevent anchor tag from triggering route change

BREAKING CHANGE: This causes the cursor style to be removed from the heading - implement CSS on the `accordion-toggle` class accordingly

Closes #4792
---
 src/accordion/docs/demo.html            | 6 ++++++
 src/accordion/test/accordion.spec.js    | 2 +-
 template/accordion/accordion-group.html | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/accordion/docs/demo.html b/src/accordion/docs/demo.html
index d72479e813..ffc5aabbab 100644
--- a/src/accordion/docs/demo.html
+++ b/src/accordion/docs/demo.html
@@ -1,3 +1,9 @@
+<style>
+  .accordion-toggle {
+    cursor: pointer;
+  }
+</style>
+
 <div ng-controller="AccordionDemoCtrl">
   <script type="text/ng-template" id="group-template.html">
     <div class="panel {{panelClass || 'panel-default'}}">
diff --git a/src/accordion/test/accordion.spec.js b/src/accordion/test/accordion.spec.js
index bcb06d509f..d9c46b7b1d 100644
--- a/src/accordion/test/accordion.spec.js
+++ b/src/accordion/test/accordion.spec.js
@@ -151,7 +151,7 @@ describe('uib-accordion', function() {
     var scope, $compile;
     var element, groups;
     var findGroupLink = function(index) {
-      return groups.eq(index).find('a').eq(0);
+      return groups.eq(index).find('.accordion-toggle').eq(0);
     };
     var findGroupBody = function(index) {
       return groups.eq(index).find('.panel-collapse').eq(0);
diff --git a/template/accordion/accordion-group.html b/template/accordion/accordion-group.html
index 1dc4c8e785..d5b8a256e2 100644
--- a/template/accordion/accordion-group.html
+++ b/template/accordion/accordion-group.html
@@ -1,7 +1,7 @@
 <div class="panel {{panelClass || 'panel-default'}}">
   <div class="panel-heading" ng-keypress="toggleOpen($event)">
     <h4 class="panel-title">
-      <a href tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" uib-accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
+      <div tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" uib-accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></div>
     </h4>
   </div>
   <div class="panel-collapse collapse" uib-collapse="!isOpen">