❌ deprecated [RFC] Settings must be persistable in the file angular.json

[JohannesHoppe]

1. It must be possible to save all settings in the file angular.json.

   {
     "projects": {
       "your-angular-project": {
         "architect": {
           "deploy": {
             "builder": "@angular-schule/ngx-deploy-starter:deploy",
             "options": {
               "setting1": "value1",
               "setting2": "value2"
             }
           }
         }
       }
     },
     "defaultProject": "your-angular-project"
   }

   The angular.json file should be the default location for saving settings, that were collected from a prompt (see RFC [RFC] A deployment builder should have an interactive prompt after the "ng add". #2)

2. Additionally, it is allowed to use an external configuration file - if this is necessary and required.
   This file can be loaded as following:

   ng deploy --configuration-file=my-configuration.json
   

I'm open for discussions:

• Name of the parameter? --configuration-file, --settings-file or something different?
• should it be recommended to leave out the parameter and select a file by convention? (as with azure.json in @Azure/ng-deploy)

FYI
@mgechev
@jamesdaniels
@santoshyadav198613
@shmool
@huv1k
@dianjuar

[JohannesHoppe]

This RFC refers to #2 (comment)

[JohannesHoppe]

This RFC is obsolet now, because the CLI got direct support of configurations for ng deploy commands:
PR #17336 as reported in Issue #17332

example:

"deploy": {
    "builder": "@deploy:deploy-builder",
    "options": {
        "buildTarget": "project:browser"
    },
    "configurations": {
        "staging": {
            "buildTarget": "project:browser:staging"
        }
    }
},

ng deploy --configuration staging

see also:
Working with multiple Firebase Projects