Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt 'clean' and 'cdnify' tasks #95

Closed
ghidello opened this issue Feb 20, 2014 · 1 comment
Closed

Grunt 'clean' and 'cdnify' tasks #95

ghidello opened this issue Feb 20, 2014 · 1 comment

Comments

@ghidello
Copy link

Hi,
the 'clean:dist' task is not removing the 'lib' folder along with package.json, Procfile and server.js files. Am I missing the point or should I try to fix it? (I must study the grunt-clean task cause I didn't find a quick way for removing everything but the .git folder).

The cdnify task should be updated for including also index.jade in it's process. I know that this step will be useless till when the grunt-google-cdn will be updated but eventually it will .. :)
I was wondering if we can try to serve html files directly into the dist folder instead of the jade files at least for the app partials. Adding the grunt-jade task into the 'build' pipeline would not be difficult and we could also think to serve the partials bundled in a js file.

I saw that you're thinking to rely on the generator-angular transforming generator-angular-fullstack in a subgenerator so I don't know about the impacts of what I'm asking.

Thanks for your work!

@DaftMonk
Copy link
Member

Hi Alessandro,

You raised some good points. The grunt clean task wasn't properly setup, I've added a commit that fixes that 31d6eb9.

It's also true that that cdnify needs to be updated for jade, I'll take a look at that.

I'd want to be careful about changing the way the views are handled so as not to cause problems with the existing folder structure, but I think it could be a good idea to use grunt-jade as part of the build pipeline for views. Mainly because you can bundle the partials as you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants