From d5d3e458e70d054707c70d058454fdd3d94070fe Mon Sep 17 00:00:00 2001 From: Eddie Monge Date: Wed, 13 Nov 2013 11:55:08 -0800 Subject: [PATCH] fix(build): standardize comments and comment out uglify:dist Standard the comment styles and add uglify to the css min commented block as it is not used anymore Fixes #455 --- templates/common/Gruntfile.js | 66 +++++++++++++++++------------------ 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/templates/common/Gruntfile.js b/templates/common/Gruntfile.js index c72ae327c..06ff9093b 100644 --- a/templates/common/Gruntfile.js +++ b/templates/common/Gruntfile.js @@ -162,9 +162,9 @@ module.exports = function (grunt) { },<% } %> // not used since Uglify task does concat, // but still available if needed - /*concat: { - dist: {} - },*/ + // concat: { + // dist: {} + // }, rev: { dist: { files: { @@ -210,31 +210,38 @@ module.exports = function (grunt) { }] } }, - cssmin: { - // By default, your `index.html` will take care of - // minification. This option is pre-configured if you do not wish to use - // Usemin blocks. - // dist: { - // files: { - // '<%%= yeoman.dist %>/styles/main.css': [ - // '.tmp/styles/{,*/}*.css', - // '<%%= yeoman.app %>/styles/{,*/}*.css' - // ] - // } - // } - }, + // By default, your `index.html` will take care of + // minification. This option is pre-configured if you do not wish to use + // Usemin blocks. + // cssmin: { + // dist: { + // files: { + // '<%%= yeoman.dist %>/styles/main.css': [ + // '.tmp/styles/{,*/}*.css', + // '<%%= yeoman.app %>/styles/{,*/}*.css' + // ] + // } + // } + // }, + // uglify: { + // dist: { + // files: { + // '<%%= yeoman.dist %>/scripts/scripts.js': [ + // '<%%= yeoman.dist %>/scripts/scripts.js' + // ] + // } + // } + // }, htmlmin: { dist: { options: { - /*removeCommentsFromCDATA: true, - // https://github.com/yeoman/grunt-usemin/issues/44 - //collapseWhitespace: true, - collapseBooleanAttributes: true, - removeAttributeQuotes: true, - removeRedundantAttributes: true, - useShortDoctype: true, - removeEmptyAttributes: true, - removeOptionalTags: true*/ + // removeCommentsFromCDATA: true, + // collapseBooleanAttributes: true, + // removeAttributeQuotes: true, + // removeRedundantAttributes: true, + // useShortDoctype: true, + // removeEmptyAttributes: true, + // removeOptionalTags: true*/ }, files: [{ expand: true, @@ -315,15 +322,6 @@ module.exports = function (grunt) { dest: '.tmp/concat/scripts' }] } - }, - uglify: { - dist: { - files: { - '<%%= yeoman.dist %>/scripts/scripts.js': [ - '<%%= yeoman.dist %>/scripts/scripts.js' - ] - } - } } });