Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.4.2] Hanzi detail page params #55

Closed
2 tasks done
anggoran opened this issue Jul 28, 2024 · 0 comments · Fixed by #58
Closed
2 tasks done

[v0.4.2] Hanzi detail page params #55

anggoran opened this issue Jul 28, 2024 · 0 comments · Fixed by #58
Assignees
@anggoran
Labels
bug Bug fixes
Milestone
小冰淇淋 - v0.5

Comments

@anggoran
Copy link
Owner

anggoran commented Jul 28, 2024 •
edited
Loading

Context

When we're navigating to the hanzi detail page, it maps with hanzi form. This causes a bug for a hanzi with multiple pinyins and meanings.

Criteria

  • Use id instead of form in params.
  • Use id instead of form in querying data.
@anggoran anggoran self-assigned this Jul 28, 2024
@anggoran anggoran converted this from a draft issue Jul 28, 2024
@anggoran anggoran added the bug Bug fixes label Jul 28, 2024
@anggoran anggoran added this to the 小冰淇淋 - v0.5 milestone Jul 28, 2024
@anggoran anggoran moved this from Todo to In Progress in 小冰淇淋 - v0.5 Jul 28, 2024
@anggoran anggoran linked a pull request Sep 15, 2024 that will close this issue
release/v0.4.2 #58
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in 小冰淇淋 - v0.5 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anggoran anggoran

Labels
bug Bug fixes
Projects
No open projects
小冰淇淋 - v0.5
Status: Done
Milestone
小冰淇淋 - v0.5
Development

Successfully merging a pull request may close this issue.

release/v0.4.2 anggoran/xiaobingqilin
1 participant
@anggoran