Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LemMinX-Maven #2

Open
AObuchow opened this issue Apr 28, 2020 · 3 comments
Open

Update to LemMinX-Maven #2

AObuchow opened this issue Apr 28, 2020 · 3 comments

Comments

@AObuchow
Copy link

AObuchow commented Apr 28, 2020

When LemMinX-Maven is stable enough, I’ll have to update vscode-xml-maven to consume it.

Since the Java plugin for VSCode by Red Hat brings m2e, the required dependencies of LemMinX-Maven might be present on the VSCode side.

Otherwise we could make an uber jar of LemMinX-Maven to bring in these dependencies. This is something we’ll have to test when we get there.

@angelozerr
Copy link
Owner

When LemMinX-Maven is stable enough, I’ll have to update vscode-xml-maven to consume it.

Great!

Since the Java plugin for VSCode by Red Hat brings m2e, the required dependencies of LemMinX-Maven might be present on the VSCode side.

I think it will be very difficult to use the JAR from vscode-java.

Otherwise we could make an uber jar of LemMinX-Maven to bring in these dependencies. This is something we’ll have to test when we get there.

Yes please.

More with redhat-developer/vscode-xml#251 we will able to avoid developping a vscode extension, juste define a user settings which links the lemminx-maven uber jar and that's all.

@AObuchow
Copy link
Author

Okay no worries, we can create an uber jar :) I think this is a good solution as it will make integration of LemMinX-Maven into other LSP clients (eg. Emacs) much simpler.

@AObuchow
Copy link
Author

Blocked by redhat-developer/vscode-xml#251 (which will make this extension obsolete when implemented.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants