Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved TextDocument update (in async) performance with TreeLineTracker #426

Closed
angelozerr opened this issue Jun 11, 2019 · 1 comment · Fixed by #448
Closed

Improved TextDocument update (in async) performance with TreeLineTracker #426

angelozerr opened this issue Jun 11, 2019 · 1 comment · Fixed by #448
Assignees
@angelozerr
Labels
performance This issue or enhancement is related to performance concerns
Milestone
v0.8.0

Comments

@angelozerr
Copy link
Contributor

Today we use ListLineTracker (coming from Eclipse Platform) which doesn't support replace method. It means that each time text is changed, the ListLineTracker recompute the all lines. Even if it's fast (around 40 ms for nasa.xml), when there are several 'textDocument/didChange' with big file like nasa.xml, the completion, foldings, etc is slow.

Ex : you type 10 characters, you wait for 40 * 10 = 400 ms.

To improve this time we can use the TreeLineTracker which supports replace. After doing some test in local, the replace method takes 0 ms, so we win 40 ms for updating TextDocument in asynch mode.
@angelozerr
Copy link
Contributor Author

Waiting for merge of #359 to create a pr

@angelozerr angelozerr added this to the v0.8.0 milestone Jun 17, 2019
@angelozerr angelozerr added the performance This issue or enhancement is related to performance concerns label Jun 17, 2019
angelozerr added a commit that referenced this issue Jun 18, 2019
@angelozerr
Use of Tree line tracker in incremental mode
10c696b 
Fix #426
angelozerr added a commit that referenced this issue Jun 18, 2019
@angelozerr
Use of Tree line tracker in incremental mode
12047fe 
Fix #426

Signed-off-by: azerr <[email protected]>
angelozerr added a commit that referenced this issue Jun 18, 2019
@angelozerr
Use of Tree line tracker in incremental mode
4ecfce9 
Fix #426

Signed-off-by: azerr <[email protected]>
angelozerr added a commit that referenced this issue Jun 18, 2019
@angelozerr
Use of Tree line tracker in incremental mode
828b11d 
Fix #426

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jun 18, 2019
Merged
angelozerr added a commit that referenced this issue Jun 18, 2019
@angelozerr
Use of Tree line tracker in incremental mode
fd482ea 
Fix #426

Signed-off-by: azerr <[email protected]>
angelozerr added a commit that referenced this issue Jun 18, 2019
@angelozerr
Use of Tree line tracker in incremental mode
3dd2d76 
Fix #426

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr changed the title Improve performance of TextDocument update (in async) with TreeLineTracker Improved TextDocument update (in async) performance with TreeLineTracker Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
performance This issue or enhancement is related to performance concerns
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Use of Tree line tracker in incremental mode eclipse-lemminx/lemminx
1 participant
@angelozerr