Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup time to do completion using SVG DTD file is slow #397

Closed
NikolasKomonen opened this issue May 27, 2019 · 0 comments
Closed

Startup time to do completion using SVG DTD file is slow #397

NikolasKomonen opened this issue May 27, 2019 · 0 comments
Assignees
@angelozerr
Labels
bug Something isn't working completion This issue or enhancement is related to completion support DTD performance This issue or enhancement is related to performance concerns
Milestone
v0.7.0

Comments

@NikolasKomonen
Copy link
Contributor

After server starts up, trying to do completion takes a while at first even with the cached DTD file.

<?xml version="1.0" standalone="no" ?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.0//EN" "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd">
<svg xmlns="http://www.w3.org/2000/svg">
    <animate attributeName="foo">
        <
    </animate>
</svg>

Screen Shot 2019-05-22 at 6 41 07 PM

There is probably a performance issue somewhere.
@NikolasKomonen NikolasKomonen changed the title Startup time for completion using SVG DTD file Startup time for completion using SVG DTD file is slow May 27, 2019
@NikolasKomonen NikolasKomonen changed the title Startup time for completion using SVG DTD file is slow Startup time to do completion using SVG DTD file is slow May 27, 2019
angelozerr added a commit that referenced this issue May 28, 2019
@angelozerr
Use DTD/XML Schema cache manager for completion
9476b37 
This PR uses like validation the cache manager to load the DTD/XML
Schema content model used for completion based on grammar, hover. It
should fix the performance problem of #397
@angelozerr angelozerr mentioned this issue May 28, 2019
Merged
@fbricon fbricon added this to the v0.7.0 milestone May 28, 2019
@fbricon fbricon added bug Something isn't working DTD performance This issue or enhancement is related to performance concerns completion This issue or enhancement is related to completion support labels May 28, 2019
angelozerr added a commit that referenced this issue May 29, 2019
@angelozerr
Use DTD/XML Schema cache manager for completion
69f2223 
This PR uses like validation the cache manager to load the DTD/XML
Schema content model used for completion based on grammar, hover. It
should fix the performance problem of #397

Signed-off-by: azerr <[email protected]>
fbricon pushed a commit that referenced this issue May 29, 2019
@angelozerr @fbricon
Use DTD/XML Schema cache manager for completion
1097abe 
This PR uses like validation the cache manager to load the DTD/XML
Schema content model used for completion based on grammar, hover. It
should fix the performance problem of #397

Signed-off-by: azerr <[email protected]>
@fbricon fbricon closed this as completed May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working completion This issue or enhancement is related to completion support DTD performance This issue or enhancement is related to performance concerns
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
3 participants
@fbricon @angelozerr @NikolasKomonen