Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse .ent and .mod files as DTD files #380

Closed
zwaldowski opened this issue May 20, 2019 · 3 comments
Closed

Parse .ent and .mod files as DTD files #380

zwaldowski opened this issue May 20, 2019 · 3 comments
Assignees
@angelozerr
Labels
DTD enhancement New feature or request
Milestone
v0.8.0

Comments

@zwaldowski
Copy link

DTDs frequently modularize long lists of entities using external files with the .ent extension. These should get syntax-checked as DTDs as well.

Technically, any extension can be used for this purpose; I've also seen .mod.
@angelozerr
Copy link
Contributor

Perhaps lsp4xml should provide a preference for thoses DTD file extensions?

@angelozerr angelozerr mentioned this issue Jul 12, 2019
Merged
@angelozerr
Copy link
Contributor

Technically, any extension can be used for this purpose; I've also seen .mod.

Yes sure but it's a little hard to do that because there are synatx coloration to manage in vscode, etc. After reading some documentation, it seems there are 3 extensions (as you said):

  • dtd
  • mod
  • ent

We need to support those extension

@angelozerr angelozerr self-assigned this Jul 17, 2019
@angelozerr angelozerr added this to the v0.8.0 milestone Jul 17, 2019
@angelozerr
Copy link
Contributor

For syntax coloration, we need wait for accept of my PR for vscode microsoft/vscode#77496

@angelozerr angelozerr changed the title .ent files should be parsed as DTDs .ent and .mod files should be parsed as DTDs Jul 17, 2019
angelozerr added a commit that referenced this issue Jul 17, 2019
@angelozerr
.ent and .mod files should be parsed as DTDs
8078485 
See #380

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jul 17, 2019
Merged
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue Jul 17, 2019
@angelozerr
.ent and .mod files should be parsed as DTDs
2b82f28 
See eclipse-lemminx/lemminx#380

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jul 17, 2019
Merged
@angelozerr angelozerr added the DTD label Jul 17, 2019
angelozerr added a commit that referenced this issue Jul 17, 2019
@angelozerr
.ent and .mod files should be parsed as DTDs
a4a1c36 
See #380

Signed-off-by: azerr <[email protected]>
angelozerr added a commit that referenced this issue Jul 17, 2019
@angelozerr
.ent and .mod files should be parsed as DTDs
04eed67 
See #380

Signed-off-by: azerr <[email protected]>
fbricon pushed a commit that referenced this issue Jul 17, 2019
@angelozerr @fbricon
.ent and .mod files should be parsed as DTDs
05a522d 
See #380

Signed-off-by: azerr <[email protected]>
fbricon pushed a commit to redhat-developer/vscode-xml that referenced this issue Jul 17, 2019
@angelozerr @fbricon
.ent and .mod files should be parsed as DTDs
cf27c86 
See eclipse-lemminx/lemminx#380

Signed-off-by: azerr <[email protected]>
@fbricon fbricon added the enhancement New feature or request label Jul 17, 2019
@fbricon fbricon closed this as completed Jul 17, 2019
@angelozerr angelozerr changed the title .ent and .mod files should be parsed as DTDs .ent and .mod files should be parsed as DTDs Jul 23, 2019
@angelozerr angelozerr changed the title .ent and .mod files should be parsed as DTDs Parse .ent and .mod files as DTD files Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
DTD enhancement New feature or request
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
3 participants
@fbricon @zwaldowski @angelozerr