Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to lsp4j 0.7.1 #370

Closed
angelozerr opened this issue May 13, 2019 · 1 comment · Fixed by #374
Closed

Move to lsp4j 0.7.1 #370

angelozerr opened this issue May 13, 2019 · 1 comment · Fixed by #374
Labels
debt This issue or enhancement is related to technical debt good first issue Good for newcomers
Milestone
v0.6.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented May 13, 2019 •
edited
Loading

Move to lsp4j 0.7.1 (last release) This change will provide compilation problem because some signature changes, but not a very hard task
@angelozerr angelozerr added debt This issue or enhancement is related to technical debt good first issue Good for newcomers labels May 13, 2019
@onyiny-ang
Copy link

I'm working through this right now. Updating lsp4j broke many of the tests as many properties now "must not be null". So far, no difficult fixes, but it may take a bit longer than originally expected :)

@NikolasKomonen NikolasKomonen added this to the v0.6.0 milestone May 15, 2019
@onyiny-ang onyiny-ang mentioned this issue May 15, 2019
Closed
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 15, 2019
@NikolasKomonen
Upgrade lsp4j version to 0.7.1 and fixed errors it introduced
8905e39 
Addition to eclipse-lemminx#372

Fixes eclipse-lemminx#370

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue May 15, 2019
Merged
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue May 16, 2019
@NikolasKomonen
Upgrade lsp4j version to 0.7.1 and fixed errors it introduced
e761137 
Addition to eclipse-lemminx#372

Fixes eclipse-lemminx#370

Signed-off-by: Nikolas Komonen <[email protected]>
fbricon pushed a commit that referenced this issue May 21, 2019
@fbricon
Upgrade lsp4j version to 0.7.1 and fixed errors it introduced
427edef 
Addition to #372

Fixes #370

Signed-off-by: Nikolas Komonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt This issue or enhancement is related to technical debt good first issue Good for newcomers
Projects
None yet
Milestone
v0.6.0
3 participants
@angelozerr @onyiny-ang @NikolasKomonen