Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Android 14 #4

Open
fredx100 opened this issue Oct 31, 2023 · 7 comments
Open

Not working on Android 14 #4

fredx100 opened this issue Oct 31, 2023 · 7 comments

Comments

@fredx100
Copy link

As far as I can tell, this isn't working on android 14 (on a pixel 7a, at least). It could be that I've set it up incorrectly. However, I setup certain numbers with their prefixes. Then, receiving messages from those numbers (with the appropriate prefixes) doesn't appear to trigger any responses. The service appears to be running (it's present on my notification bar).

Is this expected?

@anevero
Copy link
Owner

anevero commented Nov 1, 2023

Hi @fredx100, I have verified the app is working on a Pixel 7 Pro with Android 14 (although some improvements for recent Android versions are possible).

Could you please confirm if you have one or two SIM cards in your phone? If you have two SIM cards, is any of them selected as default for SMS? SMS sending code in the app relies on the fact there is a default SIM for SMS. If the default SIM is not set, the app will silently (without any user-visible errors) abort sending messages.

@fredx100
Copy link
Author

fredx100 commented Nov 1, 2023

Hi @anevero, that's great news that it's possible. I only have one sim card. Could the issue be that the received messages are sent by RCS rather than SMS? Are there any prohibited characters for the message prefix?

@anevero
Copy link
Owner

anevero commented Nov 1, 2023

@fredx100 yes, the app doesn't support RCS messages. Android handles these messages differently (and the way to handle them depends on the messaging app and phone manufacturer). Does it work if you send an SMS, not an RCS message?

@fredx100
Copy link
Author

fredx100 commented Nov 3, 2023

I've tested with SMS* and still no success. Could it be that I'm just not getting a GPS or network lock in time? I don't use google location services. Is there a way to see, in the gui or a log, whether smsgps has detected that it's received a request or would I need to debug to see that?

* I deactivated RCS on both the other phone, which was sending the request, and my own phone, which has sms_my_gps on it, just for good measure!

@fredx100
Copy link
Author

fredx100 commented Nov 3, 2023

I looked a bit further into this this afternoon. I tested it out when my phone already had a GPS lock in another app but still without success. As the phone already had a GPS location I imagine the issue can't be that it's timing out while trying to get one.

FYI I've also set the required accuracy to be the loosest (200m) for testing purposes. I also checked the permissions for the app: it has permission to access the location "when the app is running", and the app is visible in the notification bar.

Let me know if there's anything else I can try which might be useful.

@anevero
Copy link
Owner

anevero commented Nov 13, 2023

Hi @fredx100 , sorry for the late response. Unfortunately, the application doesn't save the history of received events, so it's impossible to see them in the UI.

I believe you will need to build and deploy the application via Android Studio to see any logs. If I remember correctly, it has some debug logging about SMS messages it received, and location information it fetched.

@fredx100
Copy link
Author

fredx100 commented Dec 2, 2023

Hi @anevero, sorry for my even-later response! I finally found time to look into this and the explanation is quite simple. I'd manually entered the ListItem's telephone number with a leading 0 rather than the country code, and the SmsListener then attempts to match this against the number bundled with the sms data and doesn't complete the match.

I've sent a somewhat trivial pull-request which fixes this for me by trimming any leading zero from a ListItem's number prior to matching it against the end of the sms' originating number. I will take no offence if you think there's a better implementation or approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants