perf: avoid making copies when using gRPC ByteStrings

aneoconsulting · Feb 3, 2023 · 2067925 · 2067925
1 parent 5ac4f11
commit 2067925
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/csharp/ArmoniK.Api.Client/Submitter/SubmitterClientExt.cs b/packages/csharp/ArmoniK.Api.Client/Submitter/SubmitterClientExt.cs
@@ -205,8 +205,8 @@ private static async IAsyncEnumerable<CreateLargeTaskRequest> ToRequestStream(th
                      {
                        TaskPayload = new DataChunk
                                      {
-                                       Data = ByteString.CopyFrom(taskRequest.Payload.Span.Slice(start,
-                                                                                                 chunkSize)),
+                                       Data = UnsafeByteOperations.UnsafeWrap(taskRequest.Payload.Memory.Slice(start,
+                                                                                                               chunkSize)),
                                      },
                      };
 

diff --git a/packages/csharp/ArmoniK.Api.Worker/Worker/TaskHandler.cs b/packages/csharp/ArmoniK.Api.Worker/Worker/TaskHandler.cs
@@ -162,9 +162,9 @@ await stream.RequestStream.WriteAsync(new Result
                                               CommunicationToken = Token,
                                               Data = new DataChunk
                                                      {
-                                                       Data = ByteString.CopyFrom(data.AsMemory()
-                                                                                      .Span.Slice(start,
-                                                                                                  chunkSize)),
+                                                       Data = UnsafeByteOperations.UnsafeWrap(data.AsMemory()
+                                                                                                  .Slice(start,
+                                                                                                         chunkSize)),
                                                      },
                                             })
                   .ConfigureAwait(false);

diff --git a/packages/csharp/ArmoniK.Api.Worker/Worker/TaskRequestExtensions.cs b/packages/csharp/ArmoniK.Api.Worker/Worker/TaskRequestExtensions.cs
@@ -127,8 +127,8 @@ public static IEnumerable<CreateTaskRequest> ToRequestStream(this TaskRequest ta
                      CommunicationToken = token,
                      TaskPayload = new DataChunk
                                    {
-                                     Data = ByteString.CopyFrom(taskRequest.Payload.Span.Slice(start,
-                                                                                               chunkSize)),
+                                     Data = UnsafeByteOperations.UnsafeWrap(taskRequest.Payload.Memory.Slice(start,
+                                                                                                             chunkSize)),
                                    },
                    };