Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create output dir if it doesn't exist #4

Closed
visch opened this issue Dec 21, 2021 · 3 comments
Closed

Create output dir if it doesn't exist #4

visch opened this issue Dec 21, 2021 · 3 comments

Comments

@visch
Copy link
Contributor

visch commented Dec 21, 2021

I have this problem happen so often I don't even think about it anymore.

Seems like an easy enough feature. If the output directory doesn't exist, create it.

I can't think of any negative ramifications past getting an output directory where you didn't want it to be, which I would rather have happen then seeing an exception
@andyhuynh3
Copy link
Owner

@visch This is a great idea and I took a stab at implementing this -- #7. This fix should be available in version 0.1.4 of target-jsonl. Please let me know how it goes and feel free to close this issue if it's fixed.

Thanks!

@visch
Copy link
Contributor Author

visch commented Feb 15, 2022

Looks good!

Made a video of me testing this in Meltanos slack, here's the link: https://meltano.slack.com/archives/C01V8L0NZC1/p1644940006765169

@visch visch closed this as completed Feb 15, 2022
@visch
Copy link
Contributor Author

visch commented Feb 15, 2022

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyhuynh3 @visch