Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow version ranges for dependencies. #13

Open
haleemur opened this issue Aug 31, 2023 · 0 comments · May be fixed by #14
Open

Allow version ranges for dependencies. #13

haleemur opened this issue Aug 31, 2023 · 0 comments · May be fixed by #14

Comments

@haleemur
Copy link

This package has the following dependencies

jsonschema==2.6.0
singer-python==5.8.0
adjust-precicion-for-schema==0.3.3

It would be nice to not have exact versions pinned so that the package can be installed alongside other packages.

I propose to change the dependencies to

install_requires=['jsonschema==2.6.0', 'singer-python>=5.8.0,<6.0.0', 'adjust-precision-for-schema>=0.3.3,0.4.0'],

the current singer-python's current version is 5.13.0 & adjust-precision-for-schema is currently 0.3.4

it seems reasonable to assume that any change to the public functions will be accompanied by a major version change.
@haleemur haleemur linked a pull request Sep 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

relax dependency version constraint haleemur/target-jsonl
1 participant
@haleemur