From c44d509ea82593bcd398341d30674d64ebd69567 Mon Sep 17 00:00:00 2001 From: ibaker Date: Thu, 24 Oct 2024 09:48:53 -0700 Subject: [PATCH] Remove `// Do nothing` overrides from `EventLogger` These methods are marked `default` on the `AnalyticsListener` interface with an empty implementation, so there's no need to override them just to re-define the empty implementation. PiperOrigin-RevId: 689416584 (cherry picked from commit 757f223d8aaf7a496ebd6bb42f0cd838a11860d9) --- .../media3/exoplayer/util/EventLogger.java | 28 ------------------- 1 file changed, 28 deletions(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/util/EventLogger.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/util/EventLogger.java index bc9ffcdf053..897d022e6a5 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/util/EventLogger.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/util/EventLogger.java @@ -475,13 +475,6 @@ public void onVideoSizeChanged(EventTime eventTime, VideoSize videoSize) { logd(eventTime, "videoSize", videoSize.width + ", " + videoSize.height); } - @UnstableApi - @Override - public void onLoadStarted( - EventTime eventTime, LoadEventInfo loadEventInfo, MediaLoadData mediaLoadData) { - // Do nothing. - } - @UnstableApi @Override public void onLoadError( @@ -493,27 +486,6 @@ public void onLoadError( printInternalError(eventTime, "loadError", error); } - @UnstableApi - @Override - public void onLoadCanceled( - EventTime eventTime, LoadEventInfo loadEventInfo, MediaLoadData mediaLoadData) { - // Do nothing. - } - - @UnstableApi - @Override - public void onLoadCompleted( - EventTime eventTime, LoadEventInfo loadEventInfo, MediaLoadData mediaLoadData) { - // Do nothing. - } - - @UnstableApi - @Override - public void onBandwidthEstimate( - EventTime eventTime, int totalLoadTimeMs, long totalBytesLoaded, long bitrateEstimate) { - // Do nothing. - } - @UnstableApi @Override public void onSurfaceSizeChanged(EventTime eventTime, int width, int height) {